Merged
Conversation
ralexstokes
approved these changes
Jun 1, 2022
Member
ralexstokes
left a comment
ralexstokes
left a comment
There was a problem hiding this comment.
not sure we need the level of detail for fork version and previous fork but generally like the updated presentation!
Member
I would drop the fork version + previous fork to give more width to the other columns |
Contributor
Author
|
@ralexstokes @dapplion thanks for your feedback! I pruned the columns: |
Contributor
|
Awesome! One thing we might consider is adding if it's on mainnet (and maybe a fork epoch)? I think it's mainly just nice to distinguish Bellatrix from Phase 0 and Altair in some way |
Contributor
Author
|
@djrtwo 👍 |
djrtwo
approved these changes
Jun 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fork_versions #2902, I noted the "Previous Fork" in the table.CapellaandEIP4844to README.mdPersonally, I think it looks better than before. Although HTML tags are annoying, we rarely need to update this file.